[KARAF-5089] GuardingEventHook may stop filtering listeners if one of the bundles is not valid

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.9, 4.1.1
• Fix Version/s: 4.1.2, 4.0.10
• Component/s: karaf
• Assignee: Grzegorz Grzybek
• Reporter: Grzegorz Grzybek
• Created: 11/Apr/17 07:28
• Updated: 15/Sep/18 05:45
• Resolved: 11/Apr/17 10:12

Description

I found a leak, where SCR component publishes service related to osgi.command and registration event is:

• both handled in org.apache.karaf.service.guard.impl.GuardProxyCatalog#handleProxificationForHook()
• passed to org.apache.karaf.shell.security.impl.SecuredCommandProcessorImpl#commandTracker

The reason for this is that one of the bundles iterated over in org.apache.karaf.service.guard.impl.GuardingEventHook#event may throw IllegalStateException when invoking bundleContext.getBundle().getBundleId().

When the service for command is then unregistered, the unregistration event may be this time filtered out and we have duplicate command in org.apache.felix.gogo.runtime.CommandProcessorImpl#commands