[KARAF-4215] Use of Dynamic Class Loading, Use of Externally-Controlled Input to Select Classes or Code ('Unsafe Reflection')

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 4.0.3
• Assignee: Unassigned
• Reporter: Eduardo Aguinaga
• Created: 15/Dec/15 17:58
• Updated: 27/Jan/17 16:23
• Resolved: 27/Jan/17 16:23

Description

HP Fortify SCA and SciTools Understand were used to perform an application security analysis on the karaf source code.

Dynamically loaded code has the potential to be malicious. The application uses external input with reflection to select which classes or code to use, but it does not sufficiently prevent the input from selecting improper classes or code. The constructor for DefaultJDBCLock includes one parameter for a Properties object from which the parameters for the dynamic class are taken. None of the properties are checked for content.

File: main\src\main\java\org\apache\karaf\main\lock\DefaultJDBCLock.java
Line: 365

DefaultJDBCLock.java, lines 364-369:

364 Connection doCreateConnection(String driver, String url, String username, String password) throws ClassNotFoundException, SQLException {
365     Class.forName(driver);
366     // results in a closed connection in Derby if the update lock table request timed out
367     // DriverManager.setLoginTimeout(timeout);
368     return DriverManager.getConnection(url, username, password);
369 }