Uploaded image for project: 'Karaf'
  1. Karaf
  2. KARAF-4150

bin/status fails if KARAF_DEBUG is set

    Details

      Description

      KARAF-1410 does not set the JPDA Debug options if

      if [ "x$MODE" = "xstop" ]; then
          return
      fi
      if [ "x$MODE" = "xclient" ]; then
          return
      fi
      

      but misses out on the bin/status command
      Running bin/status with KARAF_DEBUG enabled, raises the same error as in KARAF-1410.

        Issue Links

          Activity

          Hide
          tmielke Torsten Mielke added a comment - - edited

          The fix is simple:
          Simply add

          if [ "x$MODE" = "xstatus" ]; then
                  return
          fi
          

          to the karaf script in section:

          if [ "x$KARAF_DEBUG" != "x" ]; then
          ...
          fi
          
          Show
          tmielke Torsten Mielke added a comment - - edited The fix is simple: Simply add if [ "x$MODE" = "xstatus" ]; then return fi to the karaf script in section: if [ "x$KARAF_DEBUG" != "x" ]; then ... fi
          Show
          jbonofre Jean-Baptiste Onofré added a comment - Fixed on master: https://git-wip-us.apache.org/repos/asf?p=karaf.git;a=commitdiff;h=07593cc41355247324c07479ddccb7453150b854
          Show
          jbonofre Jean-Baptiste Onofré added a comment - Fixed on karaf-3.0.x: https://git-wip-us.apache.org/repos/asf?p=karaf.git;a=commitdiff;h=82b6931c40287ac3eee4cfdbcc6ddc415a5c543f
          Show
          jbonofre Jean-Baptiste Onofré added a comment - Fixed on karaf-2.x: https://git-wip-us.apache.org/repos/asf?p=karaf.git;a=commitdiff;h=3a5e5bd942956f328b479647ba04d720b24639db
          Hide
          tmielke Torsten Mielke added a comment - - edited

          Do we also need to update bin/karaf.bat in this part

          if "%KARAF_DEBUG%" == "" goto :KARAF_DEBUG_END
              if "%1" == "stop" goto :KARAF_DEBUG_END
              if "%1" == "client" goto :KARAF_DEBUG_END
          rem To be added
              if "%1" == "status" goto :KARAF_DEBUG_END 
          
          Show
          tmielke Torsten Mielke added a comment - - edited Do we also need to update bin/karaf.bat in this part if "%KARAF_DEBUG%" == "" goto :KARAF_DEBUG_END if "%1" == "stop" goto :KARAF_DEBUG_END if "%1" == "client" goto :KARAF_DEBUG_END rem To be added if "%1" == "status" goto :KARAF_DEBUG_END
          Hide
          tmielke Torsten Mielke added a comment -

          Reopening this case as I believe we also need to update bin/karaf.bat accordingly. See previous comment.

          Show
          tmielke Torsten Mielke added a comment - Reopening this case as I believe we also need to update bin/karaf.bat accordingly. See previous comment.
          Hide
          jbonofre Jean-Baptiste Onofré added a comment -

          Oh right, my bad. Let me fix that.

          Show
          jbonofre Jean-Baptiste Onofré added a comment - Oh right, my bad. Let me fix that.

            People

            • Assignee:
              jbonofre Jean-Baptiste Onofré
              Reporter:
              tmielke Torsten Mielke
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development