[KARAF-3873] TimeoutTask doesn't correctly remove pending commands

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: cellar-4.0.0, cellar-3.0.3, cellar-2.3.6
• Fix Version/s: cellar-4.0.0, cellar-3.0.4, cellar-2.3.7
• Component/s: cellar
• Assignee: Jean-Baptiste Onofré
• Reporter: Joe Hammerbacher
• Created: 23/Jul/15 17:51
• Updated: 13/Sep/18 13:06
• Resolved: 29/Jul/15 01:50

Description

TimeoutTask uses the following code to attempt to remove pending commands after the timeout period has expired:

        Boolean pending = store.getPending().containsKey(command);
        if (pending) {
            store.getPending().remove(command);
        }

However, the keys for the ConcurrentMap returned by getPending() are of type String, not Command. As a result, pending is always false (and even if it were true, remove would fail to do anything).

The intended functionality is likely:

        Boolean pending = store.getPending().containsKey(command.getId());
        if (pending) {
            store.getPending().remove(command.getId());
        }