[KARAF-3564] bin/stop fails for slave in case of Lock strategies

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.7
• Fix Version/s: 2.4.2, 2.3.11
• Component/s: karaf
• Assignee: Jean-Baptiste Onofré
• Reporter: Paolo Antinori
• Created: 25/Feb/15 15:45
• Updated: 14/Sep/18 08:35
• Resolved: 31/Mar/15 05:58

Description

bin/stop invokes org.apache.karaf.main.Stop

https://github.com/apache/karaf/blob/karaf-2.3.x/main/src/main/java/org/apache/karaf/main/Stop.java

Stop reads the socket port it has to connect to from a file: data/port is the default.

But when a Lock strategy is in place, and the instance is the one that could not obtain the lock, the shutdown socket is never started:

https://github.com/apache/karaf/blob/karaf-2.3.x/main/src/main/java/org/apache/karaf/main/Main.java#L1411-L1415

 if (lock.lock()) {
    if (lockLogged) {
       LOG.info("Lock acquired.");
    }
    setupShutdown(props);

and the Shutdown socket is created only in setupShutdown()

A workaround is to use bin/client -u admin -p admin 'shutdown --force'

It should be safe to move the invocation of setupShutdown outside the if(lock.lock()) branch

cross reference: https://issues.jboss.org/browse/ENTESB-2417