[KARAF-3411] windows startup scripts don't handle setenv.bat correctly

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 2.4.1
• Fix Version/s: 3.0.3, 2.4.1, 4.0.0.M2, 4.0.0.M3
• Component/s: karaf

Environment

Windows Any

• Assignee: Jean-Baptiste Onofré
• Reporter: Alexander Sahler
• Created: 11/Dec/14 07:47
• Updated: 14/Sep/18 08:36
• Resolved: 18/Dec/14 13:32

Description

When setting variables in setenv.bat they don't find their way to JAVA_DEFAULT_OPTS. This is due to the variable overwrite in line 231.

set DEFAULT_JAVA_OPTS=%JAVA_MODE% -Xms%JAVA_MIN_MEM% -Xmx%JAVA_MAX_MEM% -Dderby.system.home="%KARAF_DATA%\derby" -Dderby.storage.fileSyncTransactionLog=true -Dcom.sun.management.jmxremote -XX:+UnlockDiagnosticVMOptions -XX:+UnsyncloadClass

Instead it should be:

set DEFAULT_JAVA_OPTS=%JAVA_MODE% %DEFAULT_JAVA_OPTS% -Xms%JAVA_MIN_MEM% -Xmx%JAVA_MAX_MEM% -Dderby.system.home="%KARAF_DATA%\derby" -Dderby.storage.fileSyncTransactionLog=true -Dcom.sun.management.jmxremote -XX:+UnlockDiagnosticVMOptions -XX:+UnsyncloadClass

to keep the previous contents of DEFAULT_JAVA_OPTS.

The same applies for karaf.bat.