[KARAF-3103] config:edit does not correctly handle configuration visibility for --factory calls.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.4.0, 3.0.2, 4.0.0.M3
• Fix Version/s: 3.0.2, 2.4.1, 2.3.10, 4.0.0.M2, 4.0.0.M3
• Component/s: karaf
• Assignee: Jean-Baptiste Onofré
• Reporter: Richard Kaufhold
• Created: 07/Jul/14 13:39
• Updated: 13/Sep/18 19:00
• Resolved: 19/Nov/14 18:06

Description

The ConfigRepositoryImpl does not specify the visibility for created factory configurations.

I have tested it using my own ManagedServiceFactory:

Inside of the karaf shell I executed:

karaf@root()> config:edit --factory de.ansii.example.hellofactory
karaf@root()> config:property-append prop1 value1
karaf@root()> config:update

The response was:

2014-07-07 15:18:45,038 | ERROR | 04-24cc6aa84094) | configadmin | 5 - org.apache.felix.configadmin - 1.6.0 | Cannot use configuration de.ansii.example.hellofactory.5b076892-5207-4913-a704-24cc6aa84094 for [org.osgi.service.cm.ManagedServiceFactory, id=90, bundle=65/mvn:de.ansii.example/hellofactory]: No visibility to configuration bound to mvn:org.apache.karaf.config/org.apache.karaf.config.core/4.0.0-SNAPSHOT

In line 91 of /org.apache.karaf.config.core/src/main/java/org/apache/karaf/config/core/impl/ConfigRepositoryImpl.java the visibility is not specified which leads to the problem that the factory configuration created by config:edit --factory is not usable by factory implementations. (null is a sensible default, as in line 44)

Issue Links

• is related to: KARAF-3204 Avoid calls to Configuration#setBundleLocation(null) which are not needed