[KARAF-3017] Concurrency issues in FeaturesService related to add/remove/list operations

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.1, 2.3.5
• Fix Version/s: 2.4.0, 3.0.2, 2.3.6
• Assignee: Freeman Yue Fang
• Reporter: Grzegorz Grzybek
• Created: 03/Jun/14 09:35
• Updated: 27/Nov/15 09:00
• Resolved: 04/Jul/14 08:45

Description

I have concurrent scripts (using shell bin/client.sh commands) which invoke features:listurl, features:addurl and features:removeurl.

Sometimes I get NullPointerException here:

    public Repository[] listRepositories() {
        Collection<Repository> repos = repositories.values();
        return repos.toArray(new Repository[repos.size()]);
    }

when org.apache.karaf.features.internal.FeaturesServiceImpl#removeRepository(java.net.URI) is invoked between repos.size() and repos.toArray().