[KARAF-2820] features-maven-plugin:add-features-to-repo adds wrong transitive feature version

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.4
• Fix Version/s: 2.4.0, 3.0.1, 2.3.5, 4.0.0.M3
• Component/s: karaf
• Assignee: Freeman Yue Fang
• Reporter: Igor Lazebny
• Created: 12/Mar/14 12:32
• Updated: 16/Sep/18 04:34
• Resolved: 24/Mar/14 08:33

Description

features-maven-plugin:add-features-to-repo tries to find greatest version of transitive feature to add. But the problem is it compares versions as string. So, for example, "2.7.7" > "2.7.10".
Here is that part in tooling/features-maven-plugin/src/main/java/org/apache/karaf/tooling/features/AddFeaturesToRepoMojo.java

313 // looking for the feature name (with the greatest version)
314 for (String key : featuresMap.keySet()) {
315 String[] nameVersion = key.split("/");
316 if (feature.equals(nameVersion[0])) {
317 if (f == null || f.getVersion().compareTo(featuresMap.get(key).getVersion()) < 0)

{ 318 f = featuresMap.get(key); 319 }

320 }
321 }

I have an example, which adds 2 features: cxf (2.7.10) and camel (2.12.2). Expected result: 2.7.10 CXF bundles in target/features-repo. Actual result: 2.7.7 CXF bundles - as transitive through Camel features descriptor.

Issue Links

• duplicates: KARAF-2791 AddFeaturesToRepoMojo should support read version from dependency features
• is blocked by: KARAF-2821 features-maven-plugin:add-features-to-repo is broken in 2.3.5-SNAPSHOT