Uploaded image for project: 'Karaf'
  1. Karaf
  2. KARAF-2225

jaas PropertiesLoginModule does not complain when users.properties is not found but fails later

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3.2, 3.0.0
    • Component/s: karaf-core
    • Labels:
      None

      Description

      The felix Properties class we use does not throw an exception when a file is not found. Instead an empty propeties file is returned. This will lead to problems later in the login module.

      So I propose to check for existence of the users properties file and throw an exception early if it is missing.

        Activity

        Hide
        chris@die-schneider.net Christian Schneider added a comment -

        1454427 08.03.2013 16:35:14, by cschneider
        KARAF-2225 Adding checks for null and not found cases for the user properties
        M /karaf/trunk/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java
        A /karaf/trunk/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/NamePasswordHandler.java
        A /karaf/trunk/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModuleTest.java

        Show
        chris@die-schneider.net Christian Schneider added a comment - 1454427 08.03.2013 16:35:14, by cschneider KARAF-2225 Adding checks for null and not found cases for the user properties M /karaf/trunk/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java A /karaf/trunk/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/NamePasswordHandler.java A /karaf/trunk/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModuleTest.java
        Hide
        chris@die-schneider.net Christian Schneider added a comment -

        1454485 08.03.2013 19:28:07, by cschneider
        KARAF-2225 Adding checks for null and not found cases for the user properties
        M /karaf/branches/karaf-2.3.x
        M /karaf/branches/karaf-2.3.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java
        A /karaf/branches/karaf-2.3.x/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/NamePasswordHandler.java
        A /karaf/branches/karaf-2.3.x/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModuleTest.java

        Show
        chris@die-schneider.net Christian Schneider added a comment - 1454485 08.03.2013 19:28:07, by cschneider KARAF-2225 Adding checks for null and not found cases for the user properties M /karaf/branches/karaf-2.3.x M /karaf/branches/karaf-2.3.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java A /karaf/branches/karaf-2.3.x/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/NamePasswordHandler.java A /karaf/branches/karaf-2.3.x/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModuleTest.java

          People

          • Assignee:
            chris@die-schneider.net Christian Schneider
            Reporter:
            chris@die-schneider.net Christian Schneider
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development