Uploaded image for project: 'Karaf'
  1. Karaf
  2. KARAF-2121

Add Support For Displaying Gogo Commands in Karaf Shell Help

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.3.0
    • Fix Version/s: None
    • Component/s: karaf-shell
    • Labels:
      None

      Description

      Discussion on this originated in this thread:

      http://karaf.922171.n3.nabble.com/Gogo-vs-Karaf-Commands-td4027219.html

      Whist Gogo commands run in Karaf, these commands do not show up in the Karaf shell help. For Karaf users potentially needing to target multiple environments, it would be nice if Karaf could also display help for these Gogo commands.

      1. KARAF-2121.patch
        15 kB
        Göktürk Gezer

        Activity

        Hide
        jbonofre Jean-Baptiste Onofré added a comment -

        As said in a previous comment, the patch was not correct and not applicable on master neither.

        Show
        jbonofre Jean-Baptiste Onofré added a comment - As said in a previous comment, the patch was not correct and not applicable on master neither.
        Hide
        jbonofre Jean-Baptiste Onofré added a comment -

        I will refactore the patch and update especially for Karaf 3.0.0.

        Show
        jbonofre Jean-Baptiste Onofré added a comment - I will refactore the patch and update especially for Karaf 3.0.0.
        Hide
        jgoodyear Jamie goodyear added a comment -

        Bumping out to 2.3.3.

        Show
        jgoodyear Jamie goodyear added a comment - Bumping out to 2.3.3.
        Hide
        ggezer Göktürk Gezer added a comment -

        It's been a while since I wrote this patch, I'm little off the topic now. I'll re-evaluate it soon. Any insight into problem would be appreciated for reducing my catch-up time !

        Show
        ggezer Göktürk Gezer added a comment - It's been a while since I wrote this patch, I'm little off the topic now. I'll re-evaluate it soon. Any insight into problem would be appreciated for reducing my catch-up time !
        Hide
        jbonofre Jean-Baptiste Onofré added a comment -

        After testing and reviewing the patch, it's not correct, as it change the proposal number in completion: all commands are considered.

        Show
        jbonofre Jean-Baptiste Onofré added a comment - After testing and reviewing the patch, it's not correct, as it change the proposal number in completion: all commands are considered.
        Hide
        ggezer Göktürk Gezer added a comment - - edited

        With this patch:

        • Gogo commands do appear on "help" menu with their descriptions.
        • Individual command functions can also be queried with "help <scope:command>"(Information is limited only to command description and parameter descriptions those with @Descriptor annotation)("<gogo_command> --help" not supported for now, but absolutely doable)
        • CommandCompleter will also complete Gogo commands when TAB is pressed.(For Gogo commands to be taken into account, additional CommandNameCompleter reference is also added to AggregateCompleter's list in CommandCompleter)
        Show
        ggezer Göktürk Gezer added a comment - - edited With this patch: Gogo commands do appear on "help" menu with their descriptions. Individual command functions can also be queried with "help <scope:command>"(Information is limited only to command description and parameter descriptions those with @Descriptor annotation)("<gogo_command> --help" not supported for now, but absolutely doable) CommandCompleter will also complete Gogo commands when TAB is pressed.(For Gogo commands to be taken into account, additional CommandNameCompleter reference is also added to AggregateCompleter's list in CommandCompleter)

          People

          • Assignee:
            jbonofre Jean-Baptiste Onofré
            Reporter:
            gcollins Gareth Collins
          • Votes:
            5 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development