Karaf
  1. Karaf
  2. KARAF-2105

Karaf features for Spring should all be same name and use version ranges

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 2.3.1
    • Component/s: karaf-feature
    • Labels:
      None

      Description

      See
      http://karaf.922171.n3.nabble.com/Apache-Karaf-2-3-And-spring-in-the-out-of-the-box-features-files-tp4027202.html

      The spring features should all be named spring, and use version ranges to differentiate between the various spring version supported.

      Currently Spring 3.1 is named spring31, and not spring. This causes problem for end users, such as installing both spring 3.0 and 3.1, when they only want spring 3.1 etc.

      See more details in that nabble link.

      The ciritical issue is that SMX / Camel etc cannot reuse the spring features of Karaf when spring 3.1 is the new default choice.

        Activity

        Hide
        Gert Vanthienen added a comment -

        https://svn.apache.org/viewvc?view=revision&revision=1442592 also updates the names of the feature dependencies that point to other Spring 3.1 features

        Show
        Gert Vanthienen added a comment - https://svn.apache.org/viewvc?view=revision&revision=1442592 also updates the names of the feature dependencies that point to other Spring 3.1 features
        Hide
        Jean-Baptiste Onofré added a comment -

        FYI, I'm working on the Spring 3.2 update (but it requires some "mixing" in Spring bundles version as 3.2 is not a version available for all Spring bundles).

        Show
        Jean-Baptiste Onofré added a comment - FYI, I'm working on the Spring 3.2 update (but it requires some "mixing" in Spring bundles version as 3.2 is not a version available for all Spring bundles).
        Hide
        Freeman Fang added a comment -

        Hi claus,

        Not like Karaf 2.2.x has multiple spring versions for backward compatible(as Karaf 2.2.x span really long period), Karaf 3.0 only have one Spring feature version, currently it's spring 3.1.

        And we also have a ticket[1] to upgrade to spring 3.2
        [1]https://issues.apache.org/jira/browse/KARAF-2062

        Freeman

        Show
        Freeman Fang added a comment - Hi claus, Not like Karaf 2.2.x has multiple spring versions for backward compatible(as Karaf 2.2.x span really long period), Karaf 3.0 only have one Spring feature version, currently it's spring 3.1. And we also have a ticket [1] to upgrade to spring 3.2 [1] https://issues.apache.org/jira/browse/KARAF-2062 Freeman
        Hide
        Claus Ibsen added a comment -

        Yeah I think What Freeman said is that Karaf 3.0 there is no spring31 feature names, and that the out of the box spring feature version ranges is 3.1 (not 3.0 as in Karaf 2.x).

        Freeman does Karaf 3.0 have spring 2.5.6 and 3.0 version ranges for its "spring" features also? I assume not.

        Show
        Claus Ibsen added a comment - Yeah I think What Freeman said is that Karaf 3.0 there is no spring31 feature names, and that the out of the box spring feature version ranges is 3.1 (not 3.0 as in Karaf 2.x). Freeman does Karaf 3.0 have spring 2.5.6 and 3.0 version ranges for its "spring" features also? I assume not.
        Hide
        Christian Müller added a comment -

        Freeman Fang: Thanks for the clarification.
        Claus Ibsen: Maybe I misunderstood the comment: "for 3.0.0 we only ship spring 3.1 so won't have this problem"...
        However, as you said, there is a ticket for Spring 3.2 support where we should discuss this further.

        Show
        Christian Müller added a comment - Freeman Fang : Thanks for the clarification. Claus Ibsen : Maybe I misunderstood the comment: "for 3.0.0 we only ship spring 3.1 so won't have this problem"... However, as you said, there is a ticket for Spring 3.2 support where we should discuss this further.
        Hide
        Claus Ibsen added a comment -

        @Christian I dont think the Karaf team have said they wont support Spring 3.2. This ticket is about Spring 3.1 support on Karaf, to fix that "spring31" issue.

        If adding Spring 3.2 was as easy as adding a new set of features with version range [3.2,3.3) then I am sure the Karaf team can do that quickly.
        Though isn't there a problem with Spring 3.2 not being OSGi bundles? Anyway there is another Karaf ticket about Spring 3.2 support, where its better to comment.

        Show
        Claus Ibsen added a comment - @Christian I dont think the Karaf team have said they wont support Spring 3.2. This ticket is about Spring 3.1 support on Karaf, to fix that "spring31" issue. If adding Spring 3.2 was as easy as adding a new set of features with version range [3.2,3.3) then I am sure the Karaf team can do that quickly. Though isn't there a problem with Spring 3.2 not being OSGi bundles? Anyway there is another Karaf ticket about Spring 3.2 support, where its better to comment.
        Hide
        Freeman Fang added a comment -

        On trunk(for karaf 3.0.0), it's already
        <feature name="spring" description="Spring support" version="$

        {spring.version}

        " resolver="(obr)">

        Show
        Freeman Fang added a comment - On trunk(for karaf 3.0.0), it's already <feature name="spring" description="Spring support" version="$ {spring.version} " resolver="(obr)">
        Hide
        Christian Müller added a comment -

        Spring 3.2 will not be supported in Karaf 3.0.0? Really?
        However, I think you should fix this also in Karaf 3.0.0. I think it was a mistake (this was my proposal if I remember right) to name it spring3.1 instead of spring version="3.1.x". Only my 0,02 €...

        Show
        Christian Müller added a comment - Spring 3.2 will not be supported in Karaf 3.0.0? Really? However, I think you should fix this also in Karaf 3.0.0. I think it was a mistake (this was my proposal if I remember right) to name it spring3.1 instead of spring version="3.1.x". Only my 0,02 €...
        Hide
        Freeman Fang added a comment -

        commit fix
        http://svn.apache.org/viewvc?rev=1431207&view=rev for 2.3.x branch
        for 3.0.0 we only ship spring 3.1 so won't have this problem

        Show
        Freeman Fang added a comment - commit fix http://svn.apache.org/viewvc?rev=1431207&view=rev for 2.3.x branch for 3.0.0 we only ship spring 3.1 so won't have this problem

          People

          • Assignee:
            Freeman Fang
            Reporter:
            Claus Ibsen
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development