Uploaded image for project: 'Karaf'
  1. Karaf
  2. KARAF-2053

HTTP feature should install a default etc/org.ops4j.pax.web.cfg file

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 2.2.11, 2.3.2, 3.0.0
    • Component/s: karaf-webcontainer
    • Labels:
      None

      Description

      Now, when an user installs the http feature, it could be helpful to install a default etc/org.ops4j.pax.web.cfg file, containing something like:

      org.osgi.service.http.port=8181

      #org.osgi.service.http.port.secure=9101
      #org.osgi.service.http.secure.enabled=true
      #org.ops4j.pax.web.ssl.keystore=./etc/keystores/keystore.jks
      #org.ops4j.pax.web.ssl.password=password
      #org.ops4j.pax.web.ssl.keypassword=password
      #org.ops4j.pax.web.clientAuthWanted=true
      #org.ops4j.pax.web.clientAuthRequired=false

        Activity

        Hide
        ffang Freeman Fang added a comment - - edited

        Hi JB,

        As we already configure org.ops4j.pax.web PID in http feature like
        <config name="org.ops4j.pax.web">
        org.osgi.service.http.port=8181
        javax.servlet.context.tempdir=$

        {karaf.data}/pax-web-jsp
        org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
        </config>
        have another org.ops4j.pax.web.cfg in etc folder will prevent to propagate properties for the ConfigAdmin service from features config tag, this will cause jetty.xml can't be loaded as org.ops4j.pax.web.config.file, so if we put a org.ops4j.pax.web.cfg in etc folder, we at least should keep all configurations from the http feature config tag as well.

        that said, also have
        
        

        javax.servlet.context.tempdir=${karaf.data}

        /pax-web-jsp
        org.ops4j.pax.web.config.file=$

        {karaf.base}

        /etc/jetty.xml
        in etc/org.ops4j.pax.web.cfg

        
        

        Thanks
        Freeman

        Show
        ffang Freeman Fang added a comment - - edited Hi JB, As we already configure org.ops4j.pax.web PID in http feature like <config name="org.ops4j.pax.web"> org.osgi.service.http.port=8181 javax.servlet.context.tempdir=$ {karaf.data}/pax-web-jsp org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml </config> have another org.ops4j.pax.web.cfg in etc folder will prevent to propagate properties for the ConfigAdmin service from features config tag, this will cause jetty.xml can't be loaded as org.ops4j.pax.web.config.file, so if we put a org.ops4j.pax.web.cfg in etc folder, we at least should keep all configurations from the http feature config tag as well. that said, also have javax.servlet.context.tempdir=${karaf.data} /pax-web-jsp org.ops4j.pax.web.config.file=$ {karaf.base} /etc/jetty.xml in etc/org.ops4j.pax.web.cfg Thanks Freeman
        Hide
        jbonofre Jean-Baptiste Onofré added a comment -

        I gonna try again, but I don't have etc/org.ops4j.pax.web.cfg file after the installation of the http feature, which is "confusing" for the users.

        Show
        jbonofre Jean-Baptiste Onofré added a comment - I gonna try again, but I don't have etc/org.ops4j.pax.web.cfg file after the installation of the http feature, which is "confusing" for the users.
        Hide
        jbonofre Jean-Baptiste Onofré added a comment -

        Just to be clear, my proposal is more to use <configfile/> instead of <config/> in the HTTP feature.

        Show
        jbonofre Jean-Baptiste Onofré added a comment - Just to be clear, my proposal is more to use <configfile/> instead of <config/> in the HTTP feature.
        Hide
        jbonofre Jean-Baptiste Onofré added a comment -

        Thanks for the reminder Freeman

        Show
        jbonofre Jean-Baptiste Onofré added a comment - Thanks for the reminder Freeman
        Hide
        achim_nierbeck Achim Nierbeck added a comment -

        Now that we use the pax-web features this should go to pax-web as an improvement

        Show
        achim_nierbeck Achim Nierbeck added a comment - Now that we use the pax-web features this should go to pax-web as an improvement

          People

          • Assignee:
            jbonofre Jean-Baptiste Onofré
            Reporter:
            jbonofre Jean-Baptiste Onofré
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development