Karaf
  1. Karaf
  2. KARAF-1573

Potential ZipFile leak at KarArtifactInstaller.install()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.2.8
    • Fix Version/s: 2.2.9, 2.3.0, 3.0.0.RC1, 3.0.0
    • Component/s: karaf-kar
    • Labels:
      None

      Description

      zipFile.close() should be call in finally block to prevent unnecessary leak

        Activity

        Hide
        Christian Schneider added a comment -

        @Dan can you check the trunk version too. I think I made sure to close all streams there but it is always good to have a second pair of eyes.

        Show
        Christian Schneider added a comment - @Dan can you check the trunk version too. I think I made sure to close all streams there but it is always good to have a second pair of eyes.
        Hide
        Dan Tran added a comment -

        While you are at this issue, there are a few stream IO closing with similar situation as well on the same file

        Show
        Dan Tran added a comment - While you are at this issue, there are a few stream IO closing with similar situation as well on the same file
        Hide
        Christian Schneider added a comment -

        After my changes to the KarService this should not happen anymore in Karaf 3.
        @JB: I Will also take care of this in Karaf 2 if that is ok for you.

        Show
        Christian Schneider added a comment - After my changes to the KarService this should not happen anymore in Karaf 3. @JB: I Will also take care of this in Karaf 2 if that is ok for you.
        Hide
        Jean-Baptiste Onofré added a comment -

        Same in the uninstall() method.

        Show
        Jean-Baptiste Onofré added a comment - Same in the uninstall() method.

          People

          • Assignee:
            Jean-Baptiste Onofré
            Reporter:
            Dan Tran
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development