[KAFKA-9955] Exceptions thrown from SinkTask::close shadow other exceptions

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10.0.0
• Fix Version/s: 2.3.2, 2.6.0, 2.4.2, 2.5.1
• Component/s: connect
• Assignee: Greg Harris
• Reporter: Greg Harris
• Created: 05/May/20 03:52
• Updated: 16/May/20 18:09
• Resolved: 16/May/20 18:09

Description

If an exception is thrown from SinkTask::close, the exception will shadow any other previous exception, because SinkTask::close is called from within a finally block.

Steps to reproduce:

1. Throw an exception from SinkTask::start or SinkTask::put 
2. Throw an exception from SinkTask::close

Expected behavior:

• All exceptions are visible in separate log messages
• The error from SinkTask::start or SinkTask::put is logged as the exception that caused the task to stop.

Actual behavior:

• The exception from SinkTask::close is logged as the exception that caused the task to stop.
• The exceptions from either SinkTask::start or SinkTask::put are swallowed and don't appear in the logs at all.

Issue Links

• links to: GitHub Pull Request #8618