[KAFKA-937] ConsumerFetcherThread can deadlock

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.0
• Fix Version/s: 0.8.0
• Component/s: core
• Assignee: Jun Rao
• Reporter: Jun Rao
• Created: 09/Jun/13 15:25
• Updated: 04/Sep/13 03:52
• Resolved: 13/Jun/13 03:51

Description

We have the following access pattern that can introduce a deadlock.

AbstractFetcherThread.processPartitionsWithError() ->
ConsumerFetcherThread.processPartitionsWithError() ->
ConsumerFetcherManager.addPartitionsWithError() wait for lock ->
LeaderFinderThread holding lock while calling AbstractFetcherManager.shutdownIdleFetcherThreads() ->
AbstractFetcherManager calling fetcher.shutdown, which needs to wait until AbstractFetcherThread.processPartitionsWithError() completes.