[KAFKA-9330] Calling AdminClient.close in the AdminClient completion callback causes deadlock

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Assignee: Vikas Singh
• Reporter: Vikas Singh
• Created: 23/Dec/19 22:32
• Updated: 07/Jan/20 19:08
• Resolved: 07/Jan/20 19:08

Description

The close method calls `Thread.join` to wait for AdminClient thread to die, but that doesn't happen as the thread calling join is the AdminClient thread. This causes the thread to block forever, causing a deadlock where it forever waits for itself to die.

`AdminClient.close` should check if the thread calling close is same as current thread, then skip the join. The thread will check for close condition in the main loop and exit.

Issue Links

• links to: GitHub Pull Request #7866