Kafka
  1. Kafka
  2. KAFKA-931

make zookeeper.connect a required property

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, zookeeper.connect defaults to a null string. If this property is not overwritten, we will see weird NullPointerException in ZK. It will be better to make zookeeper.connect required property.

        Activity

        Hide
        Jun Rao added a comment -

        Thanks for the review. Committed to 0.8 with the suggested change.

        Show
        Jun Rao added a comment - Thanks for the review. Committed to 0.8 with the suggested change.
        Hide
        Neha Narkhede added a comment -

        +1. Minor suggestion - Can we change the default of queued.max.message.chunks to 2. Because, as long as there is one more message chunk ready to be processed, it is good enough. Having more chunks in the queue is somewhat pointless.

        Show
        Neha Narkhede added a comment - +1. Minor suggestion - Can we change the default of queued.max.message.chunks to 2. Because, as long as there is one more message chunk ready to be processed, it is good enough. Having more chunks in the queue is somewhat pointless.
        Hide
        Jun Rao added a comment -

        Attach a patch that does the following:
        1. make zookeeper.connect a required property.
        2. change the default value of auto.offset.reset to largest (to be consistent with ConsoleConsumer).
        3. change the property name queued.max.messages to make it more intuitive.

        Show
        Jun Rao added a comment - Attach a patch that does the following: 1. make zookeeper.connect a required property. 2. change the default value of auto.offset.reset to largest (to be consistent with ConsoleConsumer). 3. change the property name queued.max.messages to make it more intuitive.

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development