[KAFKA-8938] Connect - Improve Memory Allocations During Struct Validation - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 2.6.0, 2.5.1
Component/s: connect
Labels:
None

Description

Summary: Struct value validation in Kafka Connect can be optimized to avoid creating an Iterator when the expectedClasses list is of size 1. This is a meaningful enhancement for high throughput connectors.

Stack Trace from the Couchbase Kafka Connector:

java.util.Collections.singletonIterator(Object)
java.util.Collections$SingletonList.iterator()
org.apache.kafka.connect.data.ConnectSchema.validateValue(String, Schema, Object)
org.apache.kafka.connect.data.Struct.put(Field, Object)
org.apache.kafka.connect.data.Struct.put(String, Object)
com.couchbase.connect.kafka.handler.source.DefaultSchemaSourceHandler.buildValue(SourceHandlerParams, CouchbaseSourceRecord$Builder)