[KAFKA-8938] Connect - Improve Memory Allocations During Struct Validation

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.6.0, 2.5.1
• Component/s: connect
• Assignee: Unassigned
• Reporter: Auston McReynolds
• Created: 24/Sep/19 18:10
• Updated: 11/Jun/20 00:50
• Resolved: 11/Jun/20 00:50

Description

Summary: Struct value validation in Kafka Connect can be optimized to avoid creating an Iterator when the expectedClasses list is of size 1. This is a meaningful enhancement for high throughput connectors.

Stack Trace from the Couchbase Kafka Connector:

• java.util.Collections.singletonIterator(Object)
• java.util.Collections$SingletonList.iterator()
• org.apache.kafka.connect.data.ConnectSchema.validateValue(String, Schema, Object)
• org.apache.kafka.connect.data.Struct.put(Field, Object)
• org.apache.kafka.connect.data.Struct.put(String, Object)
• com.couchbase.connect.kafka.handler.source.DefaultSchemaSourceHandler.buildValue(SourceHandlerParams, CouchbaseSourceRecord$Builder)

Issue Links

• links to: GitHub Pull Request #7384