Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-8784

Remove default implementation of RocksDBConfigSetter#close

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • None
    • 3.0.0
    • streams
    • None

    Description

      In 2.3 we added a new method to RocksDBConfigSetter that will be called when a store is closed to clean up any resources that may have been created in #setConfig. Many large objects such as the block cache might be instantiated in that method, which will leak memory if not closed since they are backed by C++ objects.

      We should consider removing the default implementation to force users to pay attention to whether they may be leaking memory, even if it may be a no-op for many. Remember to update the upgrade guide when we do so to maintain a clear list of the breaking changes in 3.0

       

      Attachments

        Issue Links

          Activity

            People

              wcarlson Walker Carlson
              ableegoldman A. Sophie Blee-Goldman
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: