Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-84

commit offset before consumer shutdown

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: core
    • Labels:
      None

      Description

      To avoid duplicated messages, the consumer should do a final offset commit before shutting itself down, if autocommit is enabled.

        Activity

        Hide
        junrao Jun Rao added a comment -

        patch ready for review.

        Show
        junrao Jun Rao added a comment - patch ready for review.
        Hide
        nehanarkhede Neha Narkhede added a comment -

        Looks good.
        +1

        Show
        nehanarkhede Neha Narkhede added a comment - Looks good. +1
        Hide
        jkreps Jay Kreps added a comment -

        +1
        Nice catch!.
        For consistency it would be good if it was commitOffsets() instead of commitOffsets since the convention we (kind of) have is that things with side effects get the method style call and things with no side effects get the variable-access style call.

        Show
        jkreps Jay Kreps added a comment - +1 Nice catch!. For consistency it would be good if it was commitOffsets() instead of commitOffsets since the convention we (kind of) have is that things with side effects get the method style call and things with no side effects get the variable-access style call.

          People

          • Assignee:
            junrao Jun Rao
            Reporter:
            junrao Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development