Kafka
  1. Kafka
  2. KAFKA-829

Mirror maker needs to share the migration tool request channel

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: None
    • Component/s: tools
    • Labels:

      Description

      0.8 mirror maker suffers from the same drawbacks that the original version of the migration tool did. The consumer gets blocked if its producer queue is full, even if there are other idle producers.

      1. kafka-829-v1.patch
        10 kB
        Neha Narkhede

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        23h 48m 1 Neha Narkhede 27/Mar/13 23:06
        In Progress In Progress Patch Available Patch Available
        1m 53s 1 Neha Narkhede 27/Mar/13 23:08
        Patch Available Patch Available Resolved Resolved
        17h 51m 1 Neha Narkhede 28/Mar/13 17:00
        Resolved Resolved Closed Closed
        2s 1 Neha Narkhede 28/Mar/13 17:00
        Neha Narkhede made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Neha Narkhede made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Neha Narkhede added a comment -

        Changed the visibility of ProducerDataChannel as per your suggestion. Thanks for the review!

        Show
        Neha Narkhede added a comment - Changed the visibility of ProducerDataChannel as per your suggestion. Thanks for the review!
        Hide
        Jun Rao added a comment -

        Thanks for the patch. +1. Just one minor comment. Should ProducerDataChannel be protected at the package level like ProducerThread?

        Show
        Jun Rao added a comment - Thanks for the patch. +1. Just one minor comment. Should ProducerDataChannel be protected at the package level like ProducerThread?
        Neha Narkhede made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Neha Narkhede made changes -
        Attachment kafka-829-v1.patch [ 12575796 ]
        Hide
        Neha Narkhede added a comment -
        • Mirror maker shares the producer data channel and producer thread from migration tool.
        • Not sure what is the best place to put producer data channel and producer thread since it is relevant only to migration tool and mirror maker. So left it inside migration tool for now
        • Same caveat as migration tool. If there are failures that causes producer threads to exit, the mirror maker will not shut down cleanly and will have to be killed
        Show
        Neha Narkhede added a comment - Mirror maker shares the producer data channel and producer thread from migration tool. Not sure what is the best place to put producer data channel and producer thread since it is relevant only to migration tool and mirror maker. So left it inside migration tool for now Same caveat as migration tool. If there are failures that causes producer threads to exit, the mirror maker will not shut down cleanly and will have to be killed
        Neha Narkhede made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Neha Narkhede created issue -

          People

          • Assignee:
            Neha Narkhede
            Reporter:
            Neha Narkhede
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development