Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: controller
    • Labels:

      Description

      Before starting work on delete topic support, uploading a patch first to address some minor hiccups that touch a bunch of files:

      1. Change PartitionOfflineException to PartitionUnavailableException because in the partition state machine we mark a partition offline when its leader is down, whereas the PartitionOfflineException is thrown when all the assigned replicas of the partition are down.
      2. Change PartitionOfflineRate to UnavailablePartitionRate
      3. Remove default leader selector from partition state machine's handleStateChange. We can specify null as default when we don't need to use a leader selector.
      4. Include controller info in the client id of LeaderAndIsrRequest.
      5. Rename controllerContext.allleaders to something more meaningful - partitionLeadershipInfo.
      6. We don't need to put partition in OnlinePartition state in partition state machine initializeLeaderAndIsrForPartition, the state change occurs in handleStateChange.
      7. Add todo in handleStateChanges
      8. Left a comment above ReassignedPartitionLeaderSelector that reassigned replicas are already in the ISR (this is not true for other leader selectors), renamed the vals in the selector.

      1. kafka-813-v4.patch
        39 kB
        Swapnil Ghike
      2. kafka-813-v3.patch
        41 kB
        Swapnil Ghike
      3. kafka-813-v2.patch
        43 kB
        Swapnil Ghike
      4. kafka-813-v1.patch
        40 kB
        Swapnil Ghike

        Activity

        Swapnil Ghike created issue -
        Swapnil Ghike made changes -
        Field Original Value New Value
        Description Before starting work on delete topic support, uploading a patch first to address some minor hiccups that touch a bunch of files:

        1. Change PartitionOfflineException to PartitionUnavailableException because in the partition state machine we mark a partition offline when its leader is down, whereas the PartitionOfflineException is thrown when all the assigned replicas of the partition are down.
        2. Change PartitionOffline to UnavailablePartitionRate
        3. Remove default leader selector from partition state machine's handleStateChange. We can specify null as default when we don't need to use a leader selector.
        4. Include controller info in the client id of LeaderAndIsrRequest.
        5. Rename controllerContext.allleaders to something more meaningful - partitionLeadershipInfo.
        6. We don't need to put partition in OnlinePartition state in partition state machine initializeLeaderAndIsrForPartition, the state change occurs in handleStateChange.
        7. Add todo in handleStateChanges
        8. Left a comment above ReassignedPartitionLeaderSelector that reassigned replicas are already in the ISR (this is not true for other leader selectors), renamed the vals in the selector.
        Before starting work on delete topic support, uploading a patch first to address some minor hiccups that touch a bunch of files:

        1. Change PartitionOfflineException to PartitionUnavailableException because in the partition state machine we mark a partition offline when its leader is down, whereas the PartitionOfflineException is thrown when all the assigned replicas of the partition are down.
        2. Change PartitionOfflineRate to UnavailablePartitionRate
        3. Remove default leader selector from partition state machine's handleStateChange. We can specify null as default when we don't need to use a leader selector.
        4. Include controller info in the client id of LeaderAndIsrRequest.
        5. Rename controllerContext.allleaders to something more meaningful - partitionLeadershipInfo.
        6. We don't need to put partition in OnlinePartition state in partition state machine initializeLeaderAndIsrForPartition, the state change occurs in handleStateChange.
        7. Add todo in handleStateChanges
        8. Left a comment above ReassignedPartitionLeaderSelector that reassigned replicas are already in the ISR (this is not true for other leader selectors), renamed the vals in the selector.
        Swapnil Ghike made changes -
        Attachment kafka-813-v1.patch [ 12574284 ]
        Swapnil Ghike made changes -
        Attachment kafka-813-v2.patch [ 12574473 ]
        Swapnil Ghike made changes -
        Priority Major [ 3 ] Blocker [ 1 ]
        Swapnil Ghike made changes -
        Labels kafka-0.8
        Swapnil Ghike made changes -
        Attachment kafka-813-v3.patch [ 12574701 ]
        Swapnil Ghike made changes -
        Attachment kafka-813-v4.patch [ 12575210 ]
        Jun Rao made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Neha Narkhede made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Neha Narkhede made changes -
        Component/s controller [ 12320321 ]

          People

          • Assignee:
            Swapnil Ghike
            Reporter:
            Swapnil Ghike
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development