[KAFKA-8002] Replica reassignment to new log dir may not complete if future and current replicas segment files have different base offsets

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.1.0, 1.1.1, 2.0.0, 2.0.1, 2.1.0, 2.1.1
• Fix Version/s: 1.1.2, 2.2.0, 2.0.2, 2.1.2
• Component/s: core
• Assignee: Bob Barrett
• Reporter: Anna Povzner
• Created: 26/Feb/19 01:40
• Updated: 04/Mar/19 22:55
• Resolved: 04/Mar/19 22:55

Description

Once future replica fetches log end offset, the intended logic is to finish the move (and rename the future dir to current replica dir, etc). However, the check in Partition.maybeReplaceCurrentWithFutureReplica compares  the whole LogOffsetMetadata vs. log end offset. The resulting behavior is that the re-assignment will not finish for topic partitions that were cleaned/ compacted such that base offset of the last segment is different for the current and future replica. 

The proposed fix is to compare only log end offsets of the current and future replica.

Issue Links

• links to: GitHub Pull Request #6346
• links to: GitHub Pull Request #6364