[KAFKA-7811] Avoid unnecessary lock acquire when KafkaConsumer commits offsets

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.2.2, 0.11.0.3, 1.0.2, 1.1.1, 2.0.1, 2.1.0
• Fix Version/s: 2.3.0
• Component/s: clients
• Assignee: lambdaliu
• Reporter: lambdaliu
• Created: 10/Jan/19 13:49
• Updated: 14/Feb/19 17:49
• Resolved: 14/Feb/19 17:49

Description

In KafkaConsumer#commitAsync that does not take offset parameters, we have the following logic:

public void commitAsync(OffsetCommitCallback callback) {
    acquireAndEnsureOpen();
    try {
        commitAsync(subscriptions.allConsumed(), callback);
    } finally {
        release();
    }
}

This function calls another commitAsync with default all consumed offset which also call `acquireAndEnsureOpen`.

 

Issue Links

• links to: GitHub Pull Request #6119