[KAFKA-7518] FutureRecordMetadata.get deadline calculation from timeout is not using timeunit

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.2.0, 2.1.1
• Component/s: clients
• Assignee: Andras Katona
• Reporter: Andras Katona
• Created: 18/Oct/18 10:42
• Updated: 12/Nov/18 19:19
• Resolved: 12/Nov/18 19:19

Description

Code below assumes that timeout is in milliseconds when calculating deadline.

    @Override
    public RecordMetadata get(long timeout, TimeUnit unit) throws InterruptedException, ExecutionException, TimeoutException {
        // Handle overflow.
        long now = System.currentTimeMillis();
        long deadline = Long.MAX_VALUE - timeout < now ? Long.MAX_VALUE : now + timeout;

kafka.server.DynamicBrokerReconfigurationTest#testAdvertisedListenerUpdate failed sometimes for me and it took me to this code segment.

Issue Links

• links to: GitHub Pull Request #5815