Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-7477

Improve Streams close timeout semantics

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.1.0
    • streams

    Description

      See https://github.com/apache/kafka/pull/5682#discussion_r221473451

      The current timeout semantics are a little "magical":

      • 0 means to block forever
      • negative numbers cause the close to complete immediately without checking the state

      I think this would make more sense:

      • reject negative numbers
      • make 0 just signal and return immediately (after checking the state once)
      • if I want to wait "forever", I can use ofYears(1) or ofMillis(Long.MAX_VALUE) or some other intuitively "long enough to be forever" value instead of a magic value.

       

      Part of https://cwiki.apache.org/confluence/display/KAFKA/KIP-358%3A+Migrate+Streams+API+to+Duration+instead+of+long+ms+times

      Attachments

        Issue Links

          Activity

            People

              nizhikov Nikolay Izhikov
              vvcephei John Roesler
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: