Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-726

Add ReplicaFetcherThread name to mbean names

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.8.1
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:

      Description

      1. Add ReplicaFetcherThread name to mbean names via clientId.

      2. Use a uniform format for thread names in ConsumerFetcherThread and ReplicaFetcherThread.

      3. Modify the way kafka.server.FetcherStats are created so that the thread name is not appended twice to the mbean name.

      1. KAFKA-726.patch
        5 kB
        Swapnil Ghike
      2. KAFKA-726-v2.patch
        5 kB
        Swapnil Ghike

        Activity

        Hide
        junrao Jun Rao added a comment -

        Thanks for patch v2. Committed to 0.8.

        Show
        junrao Jun Rao added a comment - Thanks for patch v2. Committed to 0.8.
        Hide
        swapnilghike Swapnil Ghike added a comment -

        Set the clientId to name in ReplicaFetcherThread and removed ReplicaFetcherClientId from FetchRequest since it is not used anywhere else.

        Show
        swapnilghike Swapnil Ghike added a comment - Set the clientId to name in ReplicaFetcherThread and removed ReplicaFetcherClientId from FetchRequest since it is not used anywhere else.
        Hide
        nehanarkhede Neha Narkhede added a comment -

        In ReplicaFetcherThread.scala,

        the clientId can just be name, we don't need FetchRequest.ReplicaFetcherClientId anymore.

        Show
        nehanarkhede Neha Narkhede added a comment - In ReplicaFetcherThread.scala, the clientId can just be name, we don't need FetchRequest.ReplicaFetcherClientId anymore.
        Hide
        junrao Jun Rao added a comment -

        Sorry, I missed the brokerId change. Yes, you are right.

        The clientId in ReplicaFetcherThread is now replica-fetcher-ReplicaFetcherThread-fetcherId-brokerId. It probably should just be replica-fetcher-fetcherId-brokerId. We can pass that into ReplicaFetcherThread.

        Show
        junrao Jun Rao added a comment - Sorry, I missed the brokerId change. Yes, you are right. The clientId in ReplicaFetcherThread is now replica-fetcher-ReplicaFetcherThread-fetcherId-brokerId. It probably should just be replica-fetcher-fetcherId-brokerId. We can pass that into ReplicaFetcherThread.
        Hide
        swapnilghike Swapnil Ghike added a comment -

        I actually deleted brokerConfig.brokerId. ReplicaFetcherManager still passes the sourceBroker.id in the name of ReplicaFetcherThread.

        I did not understand your comment about the clientId though.

        Show
        swapnilghike Swapnil Ghike added a comment - I actually deleted brokerConfig.brokerId. ReplicaFetcherManager still passes the sourceBroker.id in the name of ReplicaFetcherThread. I did not understand your comment about the clientId though.
        Hide
        junrao Jun Rao added a comment -

        Thanks for the patch. In ReplicaFetcherManager, it's actually useful to include source broker id in the thread name since there are typically multiple ReplicaFetcherThreads on a broker. Perhaps, we can pass in clientId to ReplicaFetcherThread.

        Show
        junrao Jun Rao added a comment - Thanks for the patch. In ReplicaFetcherManager, it's actually useful to include source broker id in the thread name since there are typically multiple ReplicaFetcherThreads on a broker. Perhaps, we can pass in clientId to ReplicaFetcherThread.
        Hide
        swapnilghike Swapnil Ghike added a comment -

        As described in the description above.

        Show
        swapnilghike Swapnil Ghike added a comment - As described in the description above.

          People

          • Assignee:
            swapnilghike Swapnil Ghike
            Reporter:
            swapnilghike Swapnil Ghike
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development