Kafka
  1. Kafka
  2. KAFKA-724

Allow automatic socket.send.buffer from operating system

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.8.2.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      To do this, don't call to socket().setXXXXXXXBufferSize. This can be controlled by the configuration parameter: if the value socket.send.buffer or others are set to -1, don't call to socket().setXXXXXXXBufferSize

        Activity

        Hide
        Pablo Barrera added a comment -

        Apparently this is already fixed in 0.8.

        Show
        Pablo Barrera added a comment - Apparently this is already fixed in 0.8.
        Hide
        Jay Kreps added a comment -

        This is fixed on the old scala clients, but not on the new producer and consumer. It would be good to add the -1 means use OS default setting.

        Show
        Jay Kreps added a comment - This is fixed on the old scala clients, but not on the new producer and consumer. It would be good to add the -1 means use OS default setting.
        Hide
        ASF GitHub Bot added a comment -

        GitHub user rekhajoshm opened a pull request:

        https://github.com/apache/kafka/pull/50

        KAFKA-724: auto socket buffer set

        KAFKA-724: Allow automatic socket.send.buffer from operating system
        If socket.receive.buffer.bytes/socket.send.buffer.bytes set to non-zero/-1, the OS defaults work.Do not explicitly set buffers.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/rekhajoshm/kafka KAFKA-724

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/kafka/pull/50.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #50


        commit 118fdc3cdba2711d5d4389609da1b1fe759c5cab
        Author: Joshi <rekhajoshm@gmail.com>
        Date: 2015-02-23T02:01:58Z

        KAFKA-724: auto socket buffer set


        Show
        ASF GitHub Bot added a comment - GitHub user rekhajoshm opened a pull request: https://github.com/apache/kafka/pull/50 KAFKA-724 : auto socket buffer set KAFKA-724 : Allow automatic socket.send.buffer from operating system If socket.receive.buffer.bytes/socket.send.buffer.bytes set to non-zero/-1, the OS defaults work.Do not explicitly set buffers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rekhajoshm/kafka KAFKA-724 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit 118fdc3cdba2711d5d4389609da1b1fe759c5cab Author: Joshi <rekhajoshm@gmail.com> Date: 2015-02-23T02:01:58Z KAFKA-724 : auto socket buffer set

          People

          • Assignee:
            Unassigned
            Reporter:
            Pablo Barrera
            Reviewer:
            Jay Kreps
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development