Kafka
  1. Kafka
  2. KAFKA-724

Allow automatic socket.send.buffer from operating system

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.2.0
    • Fix Version/s: 0.10.1.0
    • Component/s: None
    • Labels:

      Description

      To do this, don't call to socket().setXXXXXXXBufferSize. This can be controlled by the configuration parameter: if the value socket.send.buffer or others are set to -1, don't call to socket().setXXXXXXXBufferSize

        Issue Links

          Activity

          Hide
          Pablo Barrera added a comment -

          Apparently this is already fixed in 0.8.

          Show
          Pablo Barrera added a comment - Apparently this is already fixed in 0.8.
          Hide
          Jay Kreps added a comment -

          This is fixed on the old scala clients, but not on the new producer and consumer. It would be good to add the -1 means use OS default setting.

          Show
          Jay Kreps added a comment - This is fixed on the old scala clients, but not on the new producer and consumer. It would be good to add the -1 means use OS default setting.
          Hide
          ASF GitHub Bot added a comment -

          GitHub user rekhajoshm opened a pull request:

          https://github.com/apache/kafka/pull/50

          KAFKA-724: auto socket buffer set

          KAFKA-724: Allow automatic socket.send.buffer from operating system
          If socket.receive.buffer.bytes/socket.send.buffer.bytes set to non-zero/-1, the OS defaults work.Do not explicitly set buffers.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rekhajoshm/kafka KAFKA-724

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/kafka/pull/50.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #50


          commit 118fdc3cdba2711d5d4389609da1b1fe759c5cab
          Author: Joshi <rekhajoshm@gmail.com>
          Date: 2015-02-23T02:01:58Z

          KAFKA-724: auto socket buffer set


          Show
          ASF GitHub Bot added a comment - GitHub user rekhajoshm opened a pull request: https://github.com/apache/kafka/pull/50 KAFKA-724 : auto socket buffer set KAFKA-724 : Allow automatic socket.send.buffer from operating system If socket.receive.buffer.bytes/socket.send.buffer.bytes set to non-zero/-1, the OS defaults work.Do not explicitly set buffers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rekhajoshm/kafka KAFKA-724 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit 118fdc3cdba2711d5d4389609da1b1fe759c5cab Author: Joshi <rekhajoshm@gmail.com> Date: 2015-02-23T02:01:58Z KAFKA-724 : auto socket buffer set
          Hide
          ASF GitHub Bot added a comment -

          Github user rekhajoshm closed the pull request at:

          https://github.com/apache/kafka/pull/50

          Show
          ASF GitHub Bot added a comment - Github user rekhajoshm closed the pull request at: https://github.com/apache/kafka/pull/50
          Hide
          ASF GitHub Bot added a comment -

          GitHub user rekhajoshm opened a pull request:

          https://github.com/apache/kafka/pull/1469

          KAFKA-724; Send, receive buffer size set if not -1

          PR #50 closed. Fixed, after rebase on trunk.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rekhajoshm/kafka KAFKA-724-rebased

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/kafka/pull/1469.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1469


          commit c9a66992b1095616f87c5748f210b973ebc7eb01
          Author: Rekha Joshi <rekhajoshm@gmail.com>
          Date: 2016-05-26T17:48:37Z

          Merge pull request #2 from apache/trunk

          Apache Kafka trunk pull

          commit 8d7fb005cb132440e7768a5b74257d2598642e0f
          Author: Rekha Joshi <rekhajoshm@gmail.com>
          Date: 2016-05-30T21:37:43Z

          Merge pull request #3 from apache/trunk

          Apache Kafka trunk pull

          commit fbef9a8fb1411282fbadec46955691c3e7ba2578
          Author: Rekha Joshi <rekhajoshm@gmail.com>
          Date: 2016-06-04T23:58:02Z

          Merge pull request #4 from apache/trunk

          Apache Kafka trunk pull

          commit feafe9714788896b00b0854eaf23c8ce5b8892ba
          Author: Joshi <rekhajoshm@gmail.com>
          Date: 2016-06-05T01:18:32Z

          KAFKA-724; Send, receive buffer size set if not -1


          Show
          ASF GitHub Bot added a comment - GitHub user rekhajoshm opened a pull request: https://github.com/apache/kafka/pull/1469 KAFKA-724 ; Send, receive buffer size set if not -1 PR #50 closed. Fixed, after rebase on trunk. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rekhajoshm/kafka KAFKA-724 -rebased Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1469.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1469 commit c9a66992b1095616f87c5748f210b973ebc7eb01 Author: Rekha Joshi <rekhajoshm@gmail.com> Date: 2016-05-26T17:48:37Z Merge pull request #2 from apache/trunk Apache Kafka trunk pull commit 8d7fb005cb132440e7768a5b74257d2598642e0f Author: Rekha Joshi <rekhajoshm@gmail.com> Date: 2016-05-30T21:37:43Z Merge pull request #3 from apache/trunk Apache Kafka trunk pull commit fbef9a8fb1411282fbadec46955691c3e7ba2578 Author: Rekha Joshi <rekhajoshm@gmail.com> Date: 2016-06-04T23:58:02Z Merge pull request #4 from apache/trunk Apache Kafka trunk pull commit feafe9714788896b00b0854eaf23c8ce5b8892ba Author: Joshi <rekhajoshm@gmail.com> Date: 2016-06-05T01:18:32Z KAFKA-724 ; Send, receive buffer size set if not -1
          Hide
          Ismael Juma added a comment -

          This was fixed on the new producer and consumer in 0.9.0.0. The PR also fixes the broker (i.e. `SocketServer`).

          Show
          Ismael Juma added a comment - This was fixed on the new producer and consumer in 0.9.0.0. The PR also fixes the broker (i.e. `SocketServer`).
          Hide
          ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/kafka/pull/1469

          Show
          ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1469

            People

            • Assignee:
              Rekha Joshi
              Reporter:
              Pablo Barrera
              Reviewer:
              Ismael Juma
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development