Kafka
  1. Kafka
  2. KAFKA-699

Disallow clients to set replicaId in FetchRequest

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: core
    • Labels:
      None

      Description

      ReplicaId in FetchRequest is for Kafka internal use. Setting it incorrectly will cause unexpected behavior in the broker. So, we shouldn't allow clients to set it.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3m 17s 1 Jun Rao 14/Jan/13 04:22
        Patch Available Patch Available Resolved Resolved
        2d 1h 4m 1 Jun Rao 16/Jan/13 05:27
        Resolved Resolved Closed Closed
        6d 16h 6m 1 Neha Narkhede 22/Jan/13 21:34
        Neha Narkhede made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.8 [ 12317244 ]
        Resolution Fixed [ 1 ]
        Hide
        Jun Rao added a comment -

        Thanks for the review. Committed to 0.8.

        Show
        Jun Rao added a comment - Thanks for the review. Committed to 0.8.
        Jun Rao made changes -
        Comment [ This doesn't seem too hard. In Processor.read(), we can add socketChannel.socket.getRemoteSocketAddress() to RequestChannel.Request. ]
        Hide
        Neha Narkhede added a comment -

        +1. Changes look good

        Show
        Neha Narkhede added a comment - +1. Changes look good
        Jun Rao made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Jun Rao made changes -
        Field Original Value New Value
        Attachment kafka-699.patch [ 12564658 ]
        Hide
        Jun Rao added a comment -

        Attach a patch. It removes replicaId from javaapi.FetchRequest and restricts the scope of the constructor in scala FetchRequest that sets replicaId.

        Show
        Jun Rao added a comment - Attach a patch. It removes replicaId from javaapi.FetchRequest and restricts the scope of the constructor in scala FetchRequest that sets replicaId.
        Jun Rao created issue -

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development