Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-699

Disallow clients to set replicaId in FetchRequest

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: core
    • Labels:
      None

      Description

      ReplicaId in FetchRequest is for Kafka internal use. Setting it incorrectly will cause unexpected behavior in the broker. So, we shouldn't allow clients to set it.

        Activity

        Hide
        junrao Jun Rao added a comment -

        Attach a patch. It removes replicaId from javaapi.FetchRequest and restricts the scope of the constructor in scala FetchRequest that sets replicaId.

        Show
        junrao Jun Rao added a comment - Attach a patch. It removes replicaId from javaapi.FetchRequest and restricts the scope of the constructor in scala FetchRequest that sets replicaId.
        Hide
        nehanarkhede Neha Narkhede added a comment -

        +1. Changes look good

        Show
        nehanarkhede Neha Narkhede added a comment - +1. Changes look good
        Hide
        junrao Jun Rao added a comment -

        Thanks for the review. Committed to 0.8.

        Show
        junrao Jun Rao added a comment - Thanks for the review. Committed to 0.8.

          People

          • Assignee:
            junrao Jun Rao
            Reporter:
            junrao Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development