Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-6928

StreamsPartitionAssignor is double retrying within InternalTopicManager

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.2.0, 2.1.1
    • streams
    • None

    Description

      Today inside StreamsPartitionAssingor, we are using the admin client to 1) check num.partitions for internal topics, 2) try to create internal topics that are not exist yet. We are using the StreamsConfig.RETRIES_CONFIG inside the InternalTopicManager to capture thrown exceptions from the resulted KafkaFuture; however inside the AdminClient, we are again using the same config with its own retrying logic.

      We should get rid of the outer retrying logic later; as of now (2018.05) there are still some issues with the admin client such that its own retrying logic is not safe. I'll leave it to hachikuji to decide when admin client's own retrying is safe to rely on.

      Attachments

        Issue Links

          Activity

            People

              guozhang Guozhang Wang
              guozhang Guozhang Wang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: