[KAFKA-6727] org.apache.kafka.clients.admin.Config has broken equals and hashCode method.

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 2.0.0
• Component/s: clients, tools
• Assignee: Andy Coates
• Reporter: Andy Coates
• Created: 29/Mar/18 12:52
• Updated: 25/Apr/18 09:42
• Resolved: 16/Apr/18 19:32

Description

`Config` makes use of `Collections.unmodifiableCollection` to wrap the supplied entries to make it immutable. Unfortunately, this breaks `hashCode` and `equals`.

From Java docs:

> The returned collection does not pass the hashCode and equals operations through to the backing collection, but relies on Object's equals and hashCode methods.

See: https://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#unmodifiableCollection(java.util.Collection)

 

 

Issue Links

• links to: GitHub Pull Request #4796