Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-667

Rename .highwatermark file

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.8.0
    • 0.8.0
    • None
    • None

    Description

      The 0.8 branch currently has a file in each log directory called
      .highwatermark
      Soon we hope to add two more files in the same format. One will hold the cleaner position for log deduplication, and the other will hold the flusher position for log flush. Each of these is sort of a "highwater mark". It would be good to rename .highwatermark to be a little bit more intuitive when we add these other files. I propose:
      replication-offset-checkpoint
      flusher-offset-checkpoint
      cleaner-offset-checkpoint
      replication-offset-checkpoint would replace the .highwatermark file. I am not making them dot files since they represent an important part of the persistent state and so the user should see it. Also shell * doesn't match hidden files, so if you did something like cp my_log/* to my_backup_log/* you would not get corresponding .highwatermark file.

      I am filing this bug now because it might be nice to just make this trivial change now and avoid having to handle backwards compatibility later.

      Attachments

        1. KAFKA-667-v1.patch
          0.5 kB
          Jay Kreps

        Activity

          People

            jkreps Jay Kreps
            jkreps Jay Kreps
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: