Kafka
  1. Kafka
  2. KAFKA-648

Use uniform convention for naming properties keys

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0, 0.8.1
    • Component/s: None
    • Labels:
      None

      Description

      Currently, the convention that we seem to use to get a property value in *Config is as follows:

      val configVal = property.getType("config.val", ...) // dot is used to separate two words in the key and the first letter of second word is capitalized in configVal.

      We should use similar convention for groupId, consumerId, clientId, correlationId.

      This change will probably be backward non-compatible.

      1. configchanges-v6-rebased.patch
        282 kB
        Sriram Subramanian
      2. configchanges-v6.patch
        283 kB
        Sriram Subramanian
      3. configchanges-v5.patch
        261 kB
        Sriram Subramanian
      4. configchanges-v4.patch
        138 kB
        Sriram Subramanian
      5. configchanges-v3.patch
        137 kB
        Sriram Subramanian
      6. configchanges-v2.patch
        108 kB
        Sriram Subramanian
      7. configchanges-1.patch
        47 kB
        Sriram Subramanian

        Activity

        Swapnil Ghike created issue -
        Neha Narkhede made changes -
        Field Original Value New Value
        Fix Version/s 0.8.1 [ 12322960 ]
        Jun Rao made changes -
        Priority Major [ 3 ] Blocker [ 1 ]
        Swapnil Ghike made changes -
        Summary Use uniform convention for naming properties keys for clientId, groupId, consumerId, correlationId Use uniform convention for naming properties keys
        Neha Narkhede made changes -
        Assignee Sriram Subramanian [ sriramsub ]
        Sriram Subramanian made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Sriram Subramanian made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Fix Version/s 0.8 [ 12317244 ]
        Sriram Subramanian made changes -
        Attachment configchanges-1.patch [ 12563174 ]
        Sriram Subramanian made changes -
        Attachment configchanges-v2.patch [ 12563666 ]
        Sriram Subramanian made changes -
        Attachment configchanges-v3.patch [ 12563847 ]
        Sriram Subramanian made changes -
        Attachment configchanges-v4.patch [ 12564016 ]
        Sriram Subramanian made changes -
        Attachment configchanges-v5.patch [ 12564296 ]
        Sriram Subramanian made changes -
        Attachment configchanges-v6.patch [ 12564480 ]
        Sriram Subramanian made changes -
        Attachment configchanges-v6-rebased.patch [ 12564516 ]
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Jun Rao made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Sriram Subramanian
            Reporter:
            Swapnil Ghike
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development