Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-648

Use uniform convention for naming properties keys

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0, 0.8.1
    • Component/s: None
    • Labels:
      None

      Description

      Currently, the convention that we seem to use to get a property value in *Config is as follows:

      val configVal = property.getType("config.val", ...) // dot is used to separate two words in the key and the first letter of second word is capitalized in configVal.

      We should use similar convention for groupId, consumerId, clientId, correlationId.

      This change will probably be backward non-compatible.

        Attachments

        1. configchanges-1.patch
          47 kB
          Sriram Subramanian
        2. configchanges-v2.patch
          108 kB
          Sriram Subramanian
        3. configchanges-v3.patch
          137 kB
          Sriram Subramanian
        4. configchanges-v4.patch
          138 kB
          Sriram Subramanian
        5. configchanges-v5.patch
          261 kB
          Sriram Subramanian
        6. configchanges-v6.patch
          283 kB
          Sriram Subramanian
        7. configchanges-v6-rebased.patch
          282 kB
          Sriram Subramanian

          Activity

            People

            • Assignee:
              sriramsub Sriram Subramanian
              Reporter:
              swapnilghike Swapnil Ghike
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: