Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-6138

Simplify StreamsBuilder#addGlobalStore

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: streams
    • Labels:

      Description

      StreamsBuilder#addGlobalStore is conceptually a 1:1 copy of Topology#addGlobalStore, that would follow DSL design principles though. Atm, StreamsBuilder#addGlobalStore does not follow provide a good user experience as it forces users to specify names for processor names – processor name are a Processor API detail should be hidden in the DSL. The current API is the following:

          public synchronized StreamsBuilder addGlobalStore(final StoreBuilder storeBuilder,
                                                            final String topic,
                                                            final String sourceName,
                                                            final Consumed consumed,
                                                            final String processorName,
                                                            final ProcessorSupplier stateUpdateSupplier)
      

      We should remove the two parameters sourceName and processorName. To be backward compatible, the current method must be deprecated and a new method should be added with reduced number of parameters. 

      KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-233%3A+Simplify+StreamsBuilder%23addGlobalStore

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                panuwat.anawatmongkhon Panuwat Anawatmongkhon
                Reporter:
                mjsax Matthias J. Sax
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: