[KAFKA-6030] Integer overflow in log cleaner cleanable ratio computation

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11.0.2, 1.0.0
• Assignee: Xin Li
• Reporter: Jason Gustafson
• Created: 09/Oct/17 19:55
• Updated: 08/Jan/18 06:43
• Resolved: 09/Oct/17 21:40

Description

In LogCleaner.LogToClean, the following computations, which are used to compute the cleanable ratio, can overflow since the segment size is an integer.

  val cleanBytes = log.logSegments(-1, firstDirtyOffset).map(_.size).sum
  ...
  val cleanableBytes = log.logSegments(firstDirtyOffset, math.max(firstDirtyOffset, firstUncleanableOffset)).map(_.size).sum

A PR is already available: https://github.com/apache/kafka/pull/4043.