Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-6024

Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None

      Description

      In several methods, parameter validation is done after calling acquireAndEnsureOpen() :

          public void seek(TopicPartition partition, long offset) {
              acquireAndEnsureOpen();
              try {
                  if (offset < 0)
                      throw new IllegalArgumentException("seek offset must not be a negative number");
      

      Since the value of parameter would not change per invocation, it seems performing validation ahead of acquireAndEnsureOpen() call would be better.

        Attachments

          Activity

            People

            • Assignee:
              sssanthalingam siva santhalingam
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: