[KAFKA-6024] Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Assignee: siva santhalingam
• Reporter: Ted Yu
• Created: 08/Oct/17 16:16
• Updated: 23/Nov/24 03:40
• Resolved: 13/Mar/18 06:03

Description

In several methods, parameter validation is done after calling acquireAndEnsureOpen() :

    public void seek(TopicPartition partition, long offset) {
        acquireAndEnsureOpen();
        try {
            if (offset < 0)
                throw new IllegalArgumentException("seek offset must not be a negative number");

Since the value of parameter would not change per invocation, it seems performing validation ahead of acquireAndEnsureOpen() call would be better.

Issue Links

• links to: GitHub Pull Request #4109
• links to: GitHub Pull Request #4109
• links to: GitHub Pull Request #4617
• links to: GitHub Pull Request #8512