[KAFKA-60] If the producer sends an invalid MessageSet the broker will append it, corrupting the log

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.6
• Assignee: Unassigned
• Reporter: Anonymous
• Created: 19/Jul/11 21:32
• Updated: 19/Jul/11 21:32
• Resolved: 19/Jul/11 21:32

Description

It appears our producer request handling is actually a little buggy. We allow messagesets to be ragged on the right (i.e. contain a trailing partial message), but when we append() we ultimately do
messages.writeTo(channel, 0, messages.sizeInBytes)
which i believe would append not just the valid messages, but also the partial message, thus corrupting the log.

We need to set limit() on the ByteBuffer to truncate off invalid trailing messages before writing, or something like that.