[KAFKA-5967] Ineffective check of negative value in CompositeReadOnlyKeyValueStore#approximateNumEntries()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.0.1
• Fix Version/s: 0.11.0.2, 1.0.0
• Component/s: streams
• Labels: beginner newbie
• Assignee: siva santhalingam
• Reporter: Ted Yu
• Created: 25/Sep/17 03:33
• Updated: 14/Nov/17 19:01
• Resolved: 04/Oct/17 17:21

Description

        long total = 0;
        for (ReadOnlyKeyValueStore<K, V> store : stores) {
            total += store.approximateNumEntries();
        }
        return total < 0 ? Long.MAX_VALUE : total;

The check for negative value seems to account for wrapping.

However, wrapping can happen within the for loop. So the check should be performed inside the loop.

Issue Links

• links to: GitHub Pull Request #3988