Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None

      Description

      system test suite has a set of default config values that are picked up from the testsuite/config directory. One can override the value of a config in the testcase_properties.json file. This is great, but the assumption is that the config property that is being overridden should also present in the testsuite/config/*.properties file.

      Currently, there are a number of properties in KafkaConfig that are not in the testsuite/config/*.properties file. So the tests might intend to override some properties, but that will be ignored.

      Let's either add all the configs in the testsuite/config/*.properties file or remove this depedency and override the property specified in testcase_properties.json.

        Activity

        Hide
        Jun Rao added a comment -

        Thanks for the patch. +1. Committed to 0.8.

        Show
        Jun Rao added a comment - Thanks for the patch. +1. Committed to 0.8.
        Hide
        John Fung added a comment -

        Uploaded kafka-586-v1.patch which contains the latest properties supported by Kafka broker.

        Show
        John Fung added a comment - Uploaded kafka-586-v1.patch which contains the latest properties supported by Kafka broker.
        Hide
        John Fung added a comment - - edited

        Hi Neha,

        In the structure of the testcase_xxxx_properties.json file as shown below, the attributes in each map are mixed with System Test properties and Broker properties:

        { "entity_id": "1", << System Test property "port": "9091", << Broker property "brokerid": "1", << System Test property "replica.fetch.min.bytes": "1", "log.file.size": "102400", "log.dir": "/tmp/kafka_server_1_logs", "log_filename": "kafka_server_9091.log", "config_filename": "kafka_server_9091.properties" }

        ,

        Since the System Test script cannot tell which property belongs to Broker, it will only match those existing properties from template and update with overridden values to the new broker properties file.

        At the mean time, the best solution is to update the template system_test/xxxx_testsuite/config/server.properties with the new properties and the test script will update them properly.

        Show
        John Fung added a comment - - edited Hi Neha, In the structure of the testcase_xxxx_properties.json file as shown below, the attributes in each map are mixed with System Test properties and Broker properties: { "entity_id": "1", << System Test property "port": "9091", << Broker property "brokerid": "1", << System Test property "replica.fetch.min.bytes": "1", "log.file.size": "102400", "log.dir": "/tmp/kafka_server_1_logs", "log_filename": "kafka_server_9091.log", "config_filename": "kafka_server_9091.properties" } , Since the System Test script cannot tell which property belongs to Broker, it will only match those existing properties from template and update with overridden values to the new broker properties file. At the mean time, the best solution is to update the template system_test/xxxx_testsuite/config/server.properties with the new properties and the test script will update them properly.

          People

          • Assignee:
            John Fung
            Reporter:
            Neha Narkhede
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development