Kafka
  1. Kafka
  2. KAFKA-585

Remove custom metrics jar and replace with latest from metrics HEAD

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      This is for at least until metrics 3.x is mavenized.

      Also:

      The KafkaCSVMetricsReporter object may be better named as KafkaMetricsReporter since startCSVMetricsReporter
      potentially starts up other (non-CSV) reporters (if any) as well - in which case KafkaMetricsReporter.scala would be a
      better place for it. Or, you can just filter out non-CSV reporters.

      Also, the top-level/config/server.properties need not enable the csv reporter. I thought the system test replication
      suite's server.properties would need to be patched, but it isn't. Should look into whether the test suite picks up the top-level
      config as a template.

      1. KAFKA-585-v1.patch
        10 kB
        Joel Koshy
      2. metrics-annotation-3.0.0-c0c8be71.jar
        5 kB
        Joel Koshy
      3. metrics-core-3.0.0-c0c8be71.jar
        80 kB
        Joel Koshy

        Activity

        Joel Koshy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Joel Koshy made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Joel Koshy made changes -
        Field Original Value New Value
        Attachment KAFKA-585-v1.patch [ 12552350 ]
        Attachment metrics-annotation-3.0.0-c0c8be71.jar [ 12552351 ]
        Attachment metrics-core-3.0.0-c0c8be71.jar [ 12552352 ]
        Joel Koshy created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Joel Koshy
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development