Kafka
  1. Kafka
  2. KAFKA-585

Remove custom metrics jar and replace with latest from metrics HEAD

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      This is for at least until metrics 3.x is mavenized.

      Also:

      The KafkaCSVMetricsReporter object may be better named as KafkaMetricsReporter since startCSVMetricsReporter
      potentially starts up other (non-CSV) reporters (if any) as well - in which case KafkaMetricsReporter.scala would be a
      better place for it. Or, you can just filter out non-CSV reporters.

      Also, the top-level/config/server.properties need not enable the csv reporter. I thought the system test replication
      suite's server.properties would need to be patched, but it isn't. Should look into whether the test suite picks up the top-level
      config as a template.

      1. KAFKA-585-v1.patch
        10 kB
        Joel Koshy
      2. metrics-annotation-3.0.0-c0c8be71.jar
        5 kB
        Joel Koshy
      3. metrics-core-3.0.0-c0c8be71.jar
        80 kB
        Joel Koshy

        Activity

        Hide
        Joel Koshy added a comment -

        The CSV reporter basically does not work if the file already exists - i.e., it doesn't try to open it in append mode. I haven't heard back from metrics-user list on that, but I think it is sufficient for now to just delete the CSV dir when starting up.

        Show
        Joel Koshy added a comment - The CSV reporter basically does not work if the file already exists - i.e., it doesn't try to open it in append mode. I haven't heard back from metrics-user list on that, but I think it is sufficient for now to just delete the CSV dir when starting up.
        Hide
        Jun Rao added a comment -

        Thanks for patch v1. +1. Just make sure that the basic system tests still work before checking in.

        Show
        Jun Rao added a comment - Thanks for patch v1. +1. Just make sure that the basic system tests still work before checking in.
        Hide
        Joel Koshy added a comment -

        Checked-in to 0.8.

        Show
        Joel Koshy added a comment - Checked-in to 0.8.

          People

          • Assignee:
            Unassigned
            Reporter:
            Joel Koshy
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development