[KAFKA-5679] Add logging to distinguish between internally and externally initiated shutdown of Kafka

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0.0
• Fix Version/s: 1.0.0
• Assignee: Rajini Sivaram
• Reporter: Apurva Mehta
• Created: 30/Jul/17 17:22
• Updated: 01/Oct/17 12:38
• Resolved: 26/Sep/17 14:23

Description

Currently, if there is an internal error that triggers a shutdown of the Kafka server, the Exit class is used, which begins the shutdown procedure. The other way a shutdown is triggered is by SIGTERM or some other signal.

We would like to distinguish between shutdown due to internal errors and external signals. This helps when debugging. Particularly, a natural question when a broker shuts down unexpectedly is: "did the deployment system send the signal or is there some un logged fatal error in the broker"?

Today, we rely on callers of Exit to log the error before making the call. However, this won't always have 100% coverage. It would be good to add a log message in Exit to record that an exit method was invoked explicitly.

We could also add a signal handler to log when SIGTERM, SIGKILL etc. are received.

This would make operating Kafka a bit easier.

Issue Links

• links to: GitHub Pull Request #3668