Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-5657

Connect REST API should include the connector type when describing a connector

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0.0
    • Fix Version/s: 1.0.0
    • Component/s: KafkaConnect
    • Labels:

      Description

      Kafka Connect's REST API's connectors/ and connectors/{name} endpoints should include whether the connector is a source or a sink.

      See KAFKA-4343 and KIP-151 for the related modification of the connector-plugins endpoint.

      Also see KAFKA-4279 for converter-related endpoints.

        Issue Links

          Activity

          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Is this something close to what you look for ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Is this something close to what you look for ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tedyu opened a pull request:

          https://github.com/apache/kafka/pull/3812

          KAFKA-5657 Connect REST API should include the connector type when describing a connector

          Embed the type of connector in ConnectorInfo

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tedyu/kafka trunk

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/kafka/pull/3812.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3812


          commit d51a65c81c576eb6a542adf92e9ab79d51f304d5
          Author: tedyu <yuzhihong@gmail.com>
          Date: 2017-09-07T23:04:48Z

          KAFKA-5657 Connect REST API should include the connector type when describing a connector


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/3812 KAFKA-5657 Connect REST API should include the connector type when describing a connector Embed the type of connector in ConnectorInfo You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/kafka trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3812.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3812 commit d51a65c81c576eb6a542adf92e9ab79d51f304d5 Author: tedyu <yuzhihong@gmail.com> Date: 2017-09-07T23:04:48Z KAFKA-5657 Connect REST API should include the connector type when describing a connector
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Randall Hauch:
          Can you take a look ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Randall Hauch : Can you take a look ?
          Hide
          rhauch Randall Hauch added a comment -

          Thanks for the PR, Ted Yu. Since this is changing the public API, we need a new KIP that would be similar to KIP-151 except that it would describe the changes for the /connectors and /connectors/{name} endpoints, including how the responses would change.

          Unfortunately, we need to move quickly if the KIP is to be approved by the Sept 13 deadline, and since voting requires 3 days we only have a day or 2 max to get the KIP ready for voting. Do you have time to create the KIP?

          Show
          rhauch Randall Hauch added a comment - Thanks for the PR, Ted Yu . Since this is changing the public API, we need a new KIP that would be similar to KIP-151 except that it would describe the changes for the /connectors and /connectors/{name } endpoints, including how the responses would change. Unfortunately, we need to move quickly if the KIP is to be approved by the Sept 13 deadline, and since voting requires 3 days we only have a day or 2 max to get the KIP ready for voting. Do you have time to create the KIP?
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          From PR:

          Who'd have thought that adding the connector type would get this complicated?

          Suggest dropping the newbie tag.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - From PR: Who'd have thought that adding the connector type would get this complicated? Suggest dropping the newbie tag.
          Hide
          ewencp Ewen Cheslack-Postava added a comment -

          Issue resolved by pull request 3812
          https://github.com/apache/kafka/pull/3812

          Show
          ewencp Ewen Cheslack-Postava added a comment - Issue resolved by pull request 3812 https://github.com/apache/kafka/pull/3812
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/kafka/pull/3812

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3812
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Can the newbie label be taken off considering how confusing the connector parameter name was ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Can the newbie label be taken off considering how confusing the connector parameter name was ?
          Hide
          ewencp Ewen Cheslack-Postava added a comment -

          Sure, it is only used to suggest JIRAs that new contributors could tackle, but I've removed it. I also added you as a contributor and assigned this to you so you get credit in JIRA as well as the git history.

          Show
          ewencp Ewen Cheslack-Postava added a comment - Sure, it is only used to suggest JIRAs that new contributors could tackle, but I've removed it. I also added you as a contributor and assigned this to you so you get credit in JIRA as well as the git history.

            People

            • Assignee:
              tedyu Ted Yu
              Reporter:
              rhauch Randall Hauch
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development