Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-5525

Streams reset tool should have same console output with or without dry-run

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: streams
    • Labels:
      None

      Description

      Hi,
      I see that the Streams reset tool provides a console output a little bit different when you execute it using "dry-run" (so without executing any real action) or without it.
      With dry-run :

      ----Dry run displays the actions which will be performed when running Streams Reset Tool----
      Following input topics offsets will be reset to beginning (for consumer group streams-wordcount)
      Topic: streams-file-input
      Done.
      Deleting all internal/auto-created topics for application streams-wordcount
      Topic: streams-wordcount-Counts-repartition
      Topic: streams-wordcount-Counts-changelog
      Done.
      

      without dry-run :

      Seek-to-beginning for input topics [streams-file-input]
      Done.
      Deleting all internal/auto-created topics for application streams-wordcount
      Topic streams-wordcount-Counts-repartition is marked for deletion.
      Note: This will have no impact if delete.topic.enable is not set to true.
      Topic streams-wordcount-Counts-changelog is marked for deletion.
      Note: This will have no impact if delete.topic.enable is not set to true.
      Done.
      

      I think that the version with dry-run related to show "Seek-to-beginning for input topics [streams-file-input]" could be used even for version without dry-run.
      The output should be consistent and the only difference should be on executing real actions or not.
      I'm working on a trivial PR for a proposal.

      Thanks,
      Paolo

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ppatierno Paolo Patierno
                Reporter:
                ppatierno Paolo Patierno
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: