[KAFKA-5525] Streams reset tool should have same console output with or without dry-run

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: streams
• Assignee: Paolo Patierno
• Reporter: Paolo Patierno
• Created: 27/Jun/17 12:12
• Updated: 05/Jul/17 22:06
• Resolved: 05/Jul/17 22:05

Description

Hi,
I see that the Streams reset tool provides a console output a little bit different when you execute it using "dry-run" (so without executing any real action) or without it.
With dry-run :

----Dry run displays the actions which will be performed when running Streams Reset Tool----
Following input topics offsets will be reset to beginning (for consumer group streams-wordcount)
Topic: streams-file-input
Done.
Deleting all internal/auto-created topics for application streams-wordcount
Topic: streams-wordcount-Counts-repartition
Topic: streams-wordcount-Counts-changelog
Done.

without dry-run :

Seek-to-beginning for input topics [streams-file-input]
Done.
Deleting all internal/auto-created topics for application streams-wordcount
Topic streams-wordcount-Counts-repartition is marked for deletion.
Note: This will have no impact if delete.topic.enable is not set to true.
Topic streams-wordcount-Counts-changelog is marked for deletion.
Note: This will have no impact if delete.topic.enable is not set to true.
Done.

I think that the version with dry-run related to show "Seek-to-beginning for input topics [streams-file-input]" could be used even for version without dry-run.
The output should be consistent and the only difference should be on executing real actions or not.
I'm working on a trivial PR for a proposal.

Thanks,
Paolo

Issue Links

• links to: GitHub Pull Request #3443