[KAFKA-5250] handleFetchRequest should do down conversion after throttling

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 0.11.0.0
• Assignee: Rajini Sivaram
• Reporter: Ismael Juma
• Created: 15/May/17 21:12
• Updated: 26/May/17 12:31
• Resolved: 26/May/17 12:31

Description

We currently do down conversion before throttling. This is good from the perspective of getting the correct message size, but it means that we can cause OOMs due to excessive memory retention. That is, by performing down conversion, we are loading the records into the heap even though we are not ready to send them yet.

It would be preferable to throttle before down conversion.

In addition, we currently updates bytesOut before throttling. We should do it after throttling as well.

Issue Links

• links to: GitHub Pull Request #3068