[KAFKA-4996] Fix findbugs multithreaded correctness warnings for streams

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: streams
• Labels: newbie
• Assignee: Leah Thomas
• Reporter: Colin McCabe
• Created: 31/Mar/17 21:19
• Updated: 30/Jun/20 20:15
• Resolved: 30/Jun/20 20:15

Description

Fix findbugs multithreaded correctness warnings for streams

Multithreaded correctness Warnings                                                                                                                                                                                                                                                        
                                                                                                                                                                                                                                                                                          
   Code Warning                                                                                                                                                                                                                                                                           
   AT   Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.kafka.streams.state.internals.Segments.getOrCreateSegment(long, ProcessorContext)                                                                                                     
   IS   Inconsistent synchronization of org.apache.kafka.streams.KafkaStreams.stateListener; locked 66% of time                                                                                                                                                                           
   IS   Inconsistent synchronization of org.apache.kafka.streams.processor.internals.StreamThread.stateListener; locked 66% of time                                                                                                                                                       
   IS   Inconsistent synchronization of org.apache.kafka.streams.processor.TopologyBuilder.applicationId; locked 50% of time                                                                                                                                                              
   IS   Inconsistent synchronization of org.apache.kafka.streams.state.internals.CachingKeyValueStore.context; locked 66% of time                                                                                                                                                         
   IS   Inconsistent synchronization of org.apache.kafka.streams.state.internals.CachingWindowStore.cache; locked 60% of time                                                                                                                                                             
   IS   Inconsistent synchronization of org.apache.kafka.streams.state.internals.CachingWindowStore.context; locked 66% of time                                                                                                                                                           
   IS   Inconsistent synchronization of org.apache.kafka.streams.state.internals.CachingWindowStore.name; locked 60% of time                                                                                                                                                              
   IS   Inconsistent synchronization of org.apache.kafka.streams.state.internals.CachingWindowStore.serdes; locked 70% of time                                                                                                                                                            
   IS   Inconsistent synchronization of org.apache.kafka.streams.state.internals.RocksDBStore.db; locked 63% of time                                                                                                                                                                      
   IS   Inconsistent synchronization of org.apache.kafka.streams.state.internals.RocksDBStore.serdes; locked 76% of time                                                                                                                                                                  

Issue Links

• is related to: KAFKA-4773 The Kafka build should run findbugs
• relates to: KAFKA-4995 Fix remaining findbugs warnings in Kafka Streams
• links to: GitHub Pull Request #2966
• links to: GitHub Pull Request #8929