[KAFKA-4930] Connect Rest API allows creating connectors with an empty name - KIP-212

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10.2.0
• Fix Version/s: 1.1.0
• Component/s: KafkaConnect
• Assignee: Sönke Liebau
• Reporter: Sönke Liebau
• Created: 22/Mar/17 09:09
• Updated: 31/Jan/18 16:51
• Resolved: 31/Jan/18 16:49

Description

The Connect Rest API allows to deploy connectors with an empty name field, which then cannot be removed through the api.

Sending the following request:

{
    "name": "",
    "config": {
        "connector.class": "org.apache.kafka.connect.tools.MockSourceConnector",
        "tasks.max": "1",
        "topics": "test-topic"
        
    }
}

Results in a connector being deployed which can be seen in the list of connectors:

[
	"",
	"testconnector"
]

But cannot be removed via a DELETE call, as the api thinks we are trying to delete the /connectors endpoint and declines the request.

I don't think there is a valid case for the connector name to be empty so perhaps we should add a check for this. I am happy to work on this.

Issue Links

• is related to: KAFKA-5563 Clarify handling of connector name in config
• supercedes: KAFKA-4938 Creating a connector with missing name parameter throws a NullPointerException
• supercedes: KAFKA-4827 Kafka connect: error with special characters in connector name
• supercedes: KAFKA-5669 Define allowed characters for connector names
• links to: GitHub Pull Request #2755
• links to: GitHub Pull Request #2755
• mentioned in: Page Loading...
• mentioned in: Page Loading...