Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-4791

Kafka Streams - unable to add state stores when using wildcard topics on the source

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.10.1.1, 0.10.2.0
    • 0.10.2.1, 0.11.0.0
    • streams
    • None
    • Java 8

    Description

      I'm trying to build up a topology (using TopologyBuilder) with following components :

      new TopologyBuilder()
        .addSource("ingest", Pattern.compile( ... ))
        .addProcessor("myprocessor", ..., "ingest")
        .addStateStore(dataStore, "myprocessor")
      

      Somehow this does not seem to work.
      When creating the topology with exact topic names, all works fine, but it seems not possible to attach state stores when using wildcard topics on the sources.

      Inside addStateStore, the processor gets connected to the state store with connectProcessorAndStateStore, and there it will try to connect the state store with the source topics from the processor: connectStateStoreNameToSourceTopics
      Here lies the problem:

          private Set<String> findSourceTopicsForProcessorParents(String [] parents) {
              final Set<String> sourceTopics = new HashSet<>();
              for (String parent : parents) {
                  NodeFactory nodeFactory = nodeFactories.get(parent);
                  if (nodeFactory instanceof SourceNodeFactory) {
                      sourceTopics.addAll(Arrays.asList(((SourceNodeFactory) nodeFactory).getTopics()));
                  } else if (nodeFactory instanceof ProcessorNodeFactory) {
                      sourceTopics.addAll(findSourceTopicsForProcessorParents(((ProcessorNodeFactory) nodeFactory).parents));
                  }
              }
              return sourceTopics;
          }
      

      The call to sourceTopics.addAll(Arrays.asList(((SourceNodeFactory) nodeFactory).getTopics())) will fail as there are no topics inside the SourceNodeFactory object, only a pattern (.getTopics returns null)

      I also tried to search for some unit tests inside the Kafka Streams project that cover this scenario, but alas, I was not able to find any.
      Only some tests on state stores with exact topic names, and some tests on wildcard topics, but no combination of both ...

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            bbejeck Bill Bejeck
            clouTrix Bart Vercammen
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment