[KAFKA-4757] Improve NetworkClient trace logging of request details

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.2.0
• Fix Version/s: 0.11.0.0
• Assignee: Colin McCabe
• Reporter: Onur Karaman
• Created: 10/Feb/17 18:57
• Updated: 22/Feb/17 04:48
• Resolved: 22/Feb/17 04:48

Description

Two issues here:
1. Here's what NetworkClient now shows when processing a disconnection:

[2017-02-10 10:48:57,052] TRACE Cancelled request org.apache.kafka.clients.NetworkClient$InFlightRequest@52f759d7 due to node 0 being disconnected (org.apache.kafka.clients.NetworkClient)

The log at one point was useful and actually showed the contents of the request. For instance, with FetchRequest, you used to be able to see which partitions were requested as well as the offsets and max bytes requested per partition.

It looks like InFlightRequest itself doesn't actually hold the request but instead currently just holds the RequestHeader. We probably want to make InFlightRequest hold the entire request to make the original request show up in the logs.

2. Sometimes I see the following log:

[2017-02-10 10:53:59,015] TRACE Sending {} to node 0. (org.apache.kafka.clients.NetworkClient)

Again not very insightful.