Kafka
  1. Kafka
  2. KAFKA-456

ProducerSendThread calls ListBuffer.size a whole bunch. That is a O(n) operation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: core
    • Labels:
    • Environment:
      NA

      Description

      Hi all,

      So there are various statements throughout the async code that call 'events.size', mostly for debugging purposes.
      Problem is that this call is O, so it could add up if the batch size is high. (it's a ListBuffer)

      I see this in at least ProducerSendThread (x4), likely more. Will factor this out myself soon when I start hacking on the project, just wanted to put this somewhere.

      1. KAFKA-456.patch
        0.8 kB
        David Arthur

        Activity

        Tony Stevenson made changes -
        Workflow Apache Kafka Workflow [ 13051092 ] no-reopen-closed, patch-avail [ 13053511 ]
        Tony Stevenson made changes -
        Workflow no-reopen-closed, patch-avail [ 12720502 ] Apache Kafka Workflow [ 13051092 ]
        Neha Narkhede made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee David Arthur [ mumrah ]
        Resolution Fixed [ 1 ]
        David Arthur made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.7.1 [ 12319140 ]
        Affects Version/s 0.7.2 [ 12322475 ]
        David Arthur made changes -
        Field Original Value New Value
        Attachment KAFKA-456.patch [ 12547723 ]
        Matthew Rathbone created issue -

          People

          • Assignee:
            David Arthur
            Reporter:
            Matthew Rathbone
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development